fix: ensure durations are integers in json formatter #2094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Ensure the nanoseconds duration in the JSON formatter is an integer.
The way we derived a single nanoseconds number from a duration object was prone to rounding errors:
We now do it a slightly different way and
Math.floor
the result to be sure. This is consistent with what some of the helpers from messages do (and why the message formatter was not affected even though we were providing higher resolution timestamps since 8.0.0).⚡️ What's your motivation?
Fixes #2086.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.