Add an additional argument setParallelCanAssign #2232
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for looking but this is still a draft PR!
🤔 What's changed?
Hi there,
First of all thank you very much for maintaining/developing cucumber!
If possible, I'd like to propose the following change based on my own requirements and other people's that I've seen here in github :)
The change is adding an additional argument to
setParallelCanAssign
which is an object with information regarding theworker
⚡️ What's your motivation?
Several folks have asked for the ability to run
features
per runner, from my own use-case this is doable if we get theCUCUMBER_WORKER_ID
.It should be available via
process.env.CUCUMBER_ID
, however that is not actually the case, see:Therefore while looking at the source-code I realised it would be simple to add the worker information as an argument to the function (or more properties if needed later)
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Do you want an object with more information other than the worker?
📋 Checklist: