Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace usage of VError with Error.cause #2363

Merged
merged 5 commits into from
Dec 21, 2023
Merged

Replace usage of VError with Error.cause #2363

merged 5 commits into from
Dec 21, 2023

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Dec 21, 2023

🤔 What's changed?

This PR removes verror, which was used to propagate errors with the original stack trace plus local context, as it is now unmaintained and is not tolerant of thrown objects that are not instances of Error.

Instead, we can make use of a newer native JavaScript feature, Error.cause, to achieve the same thing.

⚡️ What's your motivation?

Fixes #2359

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Dec 21, 2023

Coverage Status

coverage: 98.381% (-0.002%) from 98.383%
when pulling 4bf0eb2 on fix/remove-verror
into 2a95e47 on main.

@davidjgoss davidjgoss merged commit 96a65ca into main Dec 21, 2023
6 checks passed
@davidjgoss davidjgoss deleted the fix/remove-verror branch December 21, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documented way to include ts-node with esm prints warning, alternative swallows errors
2 participants