Skip to content

Get rid of ScenarioScoped #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gaeljw opened this issue Apr 13, 2025 · 0 comments
Open

Get rid of ScenarioScoped #390

gaeljw opened this issue Apr 13, 2025 · 0 comments
Labels
🏦 debt Tech debt

Comments

@gaeljw
Copy link
Member

gaeljw commented Apr 13, 2025

🤔 What's the problem you've observed?

Cucumber Java 7.22 is deprecating ScenarioScoped (cucumber/cucumber-jvm#2971).

Our codebase rely on it, because all our steps definitions are closures.

✨ Do you have a proposal for making it better?

Get inspiration from the changes done to cucumber-java8 in cucumber/cucumber-jvm#2971.

This requires some important changes mainly because most of our codebase is immutable and applying the same changes as for cucumber-java8 would mean that we have to be able to change the "body" of a AbstractGlueDefinition instance.

📚 Any additional context?

No response

@gaeljw gaeljw added the 🏦 debt Tech debt label Apr 13, 2025
gaeljw pushed a commit that referenced this issue Apr 13, 2025
For now, we add nowarn to ScenarioScoped usages. We'll take care of it in #390
gaeljw pushed a commit that referenced this issue Apr 13, 2025
For now, we add nowarn to ScenarioScoped usages. We'll take care of it in #390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt
Projects
None yet
Development

No branches or pull requests

1 participant