Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Deprecate the Formatter interface #1401

Closed
mpkorstanje opened this issue Jun 19, 2018 · 2 comments · Fixed by #1407
Closed

[Core] Deprecate the Formatter interface #1401

mpkorstanje opened this issue Jun 19, 2018 · 2 comments · Fixed by #1407
Assignees
@mlvandijk
Labels
good first issue Good for newcomers
Milestone
4.0.0

Comments

@mpkorstanje
Copy link
Contributor

They formatter interface is a marker interface that used to inform Cucumber that the class implementing it was a plug-in that should be provided with events. This functionality has since fallen apart into Plugin and EventListener.

All usages of Formatter can be replaced with Plugin and EventListener. The class itself can be deprecated.
@mpkorstanje mpkorstanje added the good first issue Good for newcomers label Jun 19, 2018
@aslakhellesoy
Copy link
Contributor

Sounds good. There will be a lot of breaking changes when we integrate cucumber/common#416. I suggest we remove it then.

@mpkorstanje mpkorstanje added this to the 4.0.0 milestone Jun 20, 2018
@mlvandijk mlvandijk mentioned this issue Jun 28, 2018
Merged
7 tasks
@mpkorstanje mpkorstanje mentioned this issue Jun 29, 2018
Merged
6 tasks
@mpkorstanje mpkorstanje changed the title Deprecate the Formatter interface [Core] Deprecate the Formatter interface Jun 29, 2018
@mlvandijk mlvandijk mentioned this issue Jul 9, 2018
Closed
@mlvandijk mlvandijk self-assigned this Jul 13, 2018
mpkorstanje pushed a commit that referenced this issue Jul 27, 2018
@mlvandijk @mpkorstanje
[Core] Deprecate Formatter interface (#1407)
c3d167f 
Fixes: #1401, #1408,
@lock
Copy link

lock bot commented Jul 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mlvandijk mlvandijk

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

[Core] Deprecate Formatter interface cucumber/cucumber-jvm
3 participants
@aslakhellesoy @mpkorstanje @mlvandijk