Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JUnit Platform Engine docs #2677

Closed
mpkorstanje opened this issue Jan 11, 2023 · 1 comment · Fixed by #2681
Closed

Update JUnit Platform Engine docs #2677

mpkorstanje opened this issue Jan 11, 2023 · 1 comment · Fixed by #2681
Labels
⚡ enhancement Request for new functionality

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Jan 11, 2023 •
edited
Loading

🤔 What's the problem you're trying to solve?

With junit-team/junit5#3044 released in 5.9.1 the docs for the platform engine still state:

Note: Cucumber does not guarantee that the number of concurrently executing tests will not exceed the configured parallelism. The underlying ForkJoinPool used to execute scenarios may spawn additional threads. To obtain such guarantees us a custom parallel configuration strategy.

✨ What's your proposed solution?

Update the docs to explain that since 5.9.12 the property can be used. Also add the property to the list of properties.

📚 Any additional context?

Fixes: #2512.
@mpkorstanje mpkorstanje added the ⚡ enhancement Request for new functionality label Jan 11, 2023
@fslev
Copy link

fslev commented Jan 11, 2023

Since 5.9.2

mpkorstanje added a commit that referenced this issue Jan 12, 2023
@mpkorstanje
[JUnit Platform] Document fixed.max-pool-size property
ab96284 
With JUnit 5.9.2 we pull in junit-team/junit5#3044 which makes it
possible to limit the maximum number of threads used while
executing in parallel.

Closes: #2677
@mpkorstanje mpkorstanje mentioned this issue Jan 12, 2023
Merged
mpkorstanje added a commit that referenced this issue Jan 12, 2023
@mpkorstanje
[JUnit Platform] Document fixed.max-pool-size property
15ade67 
With JUnit 5.9.2 we pull in junit-team/junit5#3044 which makes it
possible to limit the maximum number of threads used while
executing in parallel.

Closes: #2677
mpkorstanje added a commit that referenced this issue Jan 12, 2023
@mpkorstanje
[JUnit Platform] Document fixed.max-pool-size property (#2681)
4bbab4b 
With JUnit 5.9.2 we pull in junit-team/junit5#3044 which makes it
possible to limit the maximum number of threads used while
executing in parallel.

Closes: #2677
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
⚡ enhancement Request for new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[JUnit Platform] Document fixed.max-pool-size property cucumber/cucumber-jvm
2 participants
@mpkorstanje @fslev