@txn should have a default @Order

[mmalmeida]

the @TxN hook is added if you define cucumber.runtime.java.spring.hooks in your hook.

However, with the current implementation you cannot seem to add any other @before hook that runs before that one.

Suggestion: Add a default @order(10) to that hook, so we can add before hooks before that one.

[aslakhellesoy]

I need to refresh my memory and read through #46 again. It's from before I started maintaining a proper History.md

[mmalmeida]

Sure.If you want any help with it let me know. If you think this is something worth doing I can take care of this ticket.

[aslakhellesoy]

Allright, I think this makes sense. Let's make it a higher number - 10 seems arbitrailiy low. How about 1000?

[mmalmeida]

I think 1000 might be too high if we want to have hooks before and after this one - you'll need to give a number higher than 1000 to the ones ran after this one. Maybe 100 would suffice? I'm not sure there are many use cases where one would have 100 other hooks (and even then, you can repeat order numbers).

[aslakhellesoy]

Ok 100 then :-)

On Wed, Oct 10, 2012 at 8:43 AM, Miguel Almeida notifications@github.comwrote:

I think 1000 might be too high if we want to have hooks before _and_after this one - you'll need to give a number higher than 1000 to the ones
ran after this one. Maybe 100 would suffice? I'm not sure there are many
use cases where one would have 100 other hooks (and even then, you can
repeat order numbers).

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/398#issuecomment-9292758.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.