cucumber-spring should use TestContextManager

[aslakhellesoy]

Spring's JUnit and TestNG runners use org.springframework.test.context.TestContextManager internally. This class is available in org.springframework:spring-test:3.2.0.RELEASE.

I think that using this internally somewhere in cucumber.runtime.java.spring would make it easier to fix #438 and possibly simplify/improve the cucumber-spring module as well.

I'm not familiar enough with Spring to implement this, so it would be great to get some help from previous cucumber-spring contributors. /cc @ffbit @vladimirkl @paoloambrosio @andrena @ovstetun

[pasviegas]

I know its not perfect, but something like this on the SpringFactory should work. Actually it is close to what SpringJunit4ClassRunner does.

public <T> T getInstance(final Class<T> type) {
        try {
            T instance = createTest(type);
            TestContextManager contextManager = new TestContextManager(type);
            contextManager.prepareTestInstance(instance);
            return instance;
        } catch (Exception exception) {
            throw new CucumberException(exception.getMessage(), exception);
        }
    }

    @SuppressWarnings("unchecked")
    protected <T> T createTest(Class<T> type) throws Exception {
        return (T) type.getConstructors()[0].newInstance();
    }

[aslakhellesoy]

Would you be interested in sending a pull request for this with some tests?

[pasviegas]

Sure, I'll send it this week! =)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.