Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate class in 1.1.3 release cucumber.api.DataTable #518

Closed
pranasblk opened this issue May 13, 2013 · 6 comments
Closed

Duplicate class in 1.1.3 release cucumber.api.DataTable #518

pranasblk opened this issue May 13, 2013 · 6 comments

Comments

@pranasblk
Copy link

Duplicate java class in 1.1.3 release cucumber.api.DataTable
It is deployed as cucumber-core and cucumber-groovy in 1.1.3

@aslakhellesoy
Copy link
Contributor

This is because we use the maven shade plugin to include the cucumber-core classes (and other jar dependencies) in the cucumber-groovy jar. Perhaps we should stop doing that.

@ffbit
Copy link
Contributor

ffbit commented May 15, 2013

@pranasblk Could you provide more details about the problem, please?

Update: please ignore the rest of the comment.

I've tried to do a quick investigation with the following steps:

  • checked out the v1.1.3 tag
  • built the cucumber-groovy artifact, which lays in the groovy folder
  • opened the cucumber-groovy cucumber-groovy-1.1.3.jar in midnight commander
  • walked to the cucumber.api package
  • and got the following list of compiled classes

screen shot 2013-05-15 at 21 04 34

Also I've downloaded cucumber-groovy-1.1.3.jar from Maven Central, looked inside it and got the same compiled classes list.

Looking forward to your details.
Thanks in advance.

@pranasblk
Copy link
Author

I believe what is in the build same goes to the maven central repository, but real issue is duplicate classes in different archives in the same Cucumber-JVM release.
screenshot

@aslakhellesoy
Copy link
Contributor

Why are you still discussing this? I said it's because of the shade plugin.

@aslakhellesoy
Copy link
Contributor

Closing this - fixed by #522.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
mpkorstanje pushed a commit that referenced this issue Oct 4, 2019
mpkorstanje pushed a commit that referenced this issue Oct 4, 2019
mpkorstanje pushed a commit that referenced this issue Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants