Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an enum for result status. #1133

Merged
merged 1 commit into from
May 25, 2017
Merged

Use an enum for result status. #1133

merged 1 commit into from
May 25, 2017

Conversation

brasmusson
Copy link
Contributor

Summary

Instead of using string constants, use an enum for the result status
(passed, failed, ...).

Motivation and Context

Based on a review comment on the upgrade to a newer Gherkin version, that pointed to the problem of using string constants for result status (the result class in Gherkin2 did not have a string constant for the pending status, making matter more complicated), I have introduced an enum in the Result class for the possible result statuses

How Has This Been Tested?

The test suites has been updated and amended to, so it covers the change from strings to enum constants for result statuses.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Instead of using string constants, use an enum for the result status
(passed, failed, ...).
@brasmusson brasmusson mentioned this pull request May 25, 2017
@mattwynne mattwynne merged commit 68b73c5 into master May 25, 2017
@brasmusson brasmusson deleted the result-status-enum branch May 26, 2017 11:53
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants