Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java8] Replace ConstantPoolTypeIntrospector #1178

Merged
merged 3 commits into from
Jul 29, 2017
Merged

[Java8] Replace ConstantPoolTypeIntrospector #1178

merged 3 commits into from
Jul 29, 2017

Commits on Jul 29, 2017

  1. [Java8] Replace ConstantPoolTypeIntrospector with TypeResolver 

    To determine which argument types a lambda function requires we created a
 ConstantPoolTypeIntrospector. However it has never functioned quite correctly
 (#937, #1140, #957), was prone to breaking (#912, #914) and hasn't been tested
 much (#1048).

It is important to understand that while we will get a properly functioning and
 tested replacement, TypeResolver uses the same ConstantPool and thus has the
 same potential to break. However because TypeResolver is used by a much larger
 audience I expect these problems to be shallow.

Because this change the interface of Java8StepDefinition it made sense to
 refactor all the Java8 related stuff out of cucumber-java. This will make it easier in
 the future to add things like KotlinStepDefintions without creating a separate
 KotlinBackend.

Related issues:
 - #912
 - #914
 - #937
 - #957
 - #1140
 - #1048
 - #1140

Closes #937
Closes #1048
    @mpkorstanje
    mpkorstanje committed Jul 29, 2017
    Configuration menu
    Copy the full SHA
    657ce3a View commit details
    Browse the repository at this point in the history

  2. [Java] Remove test only constructors from JavaBackend 

    The JavaBackend had several test only constructors cluttering up the
 interface. Mostly due to poor setup in the tests themselves. By
 improving the test setup we can remove these constructors.
    @mpkorstanje
    mpkorstanje committed Jul 29, 2017
    Configuration menu
    Copy the full SHA
    9afd72e View commit details
    Browse the repository at this point in the history

  3. Update the History.md wrt Replace ConstantPoolTypeIntrospector

    @mpkorstanje
    mpkorstanje committed Jul 29, 2017
    Configuration menu
    Copy the full SHA
    7f50aed View commit details
    Browse the repository at this point in the history