[Core] Fix race condition in Timeout #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to ensure a happens before relation exists between these events; a. the timer setting the interrupt flag on the execution thread. b. terminating and cleaning up the timer To do this we synchronize on monitor. The atomic boolean is merely a convenient container. Additionally Timeout did not throw any exceptions when the callback was busy waiting but did set the interrupted flag. To resolve this we check and throw after the completion of the callback. This fixes #1241
mpkorstanje
commented
Oct 11, 2017
There was a problem hiding this comment.
@brasmusson @aslakhellesoy this code is not pretty. To make it pretty we'd have to effectively make cucumber multithreaded. So I think it'd be best to focus on its validity.
mpkorstanje
changed the title
aslakhellesoy
approved these changes
Oct 12, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need to ensure a happens before relation exists between these events;
a. the timer setting the interrupt flag on the execution thread.
b. terminating and cleaning up the timer
To do this we synchronize on monitor. The atomic boolean is merely a
convenient container.
Additionally Timeout did not throw any exceptions when the callback
was busy waiting but did set the interrupted flag. To resolve this
we check and throw after the completion of the callback.
This fixes #1241
Types of changes
Checklist: