cucumber-core: Use the docstring content type in the json formatter.

[rjwittams]

Summary

Docstring content type is currently not carried down into the json formatter.
This worked in 1.2.5.
PickleString did not have the corresponding field, so I added that in:
cucumber/common#292
(The mono repo PR is required for this one to compile, so this will fail CI).

#1263
Fixing this bug.

Passes the contentType field down into the map that gets json serialized.
Uses the content_type name to match 1.2.5 and other language reports.

Motivation and Context

#1263

How Has This Been Tested?

Unit test added.
All tests run, Pax Exam Calculator Test appears to be broken before this change, due to a deployment issue?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

I do not know if any docs need changing. I expect not as this is a regression from 1.2.5

[mlvandijk]

@rjwittams Thank you for submitting a PR. Unfortunately the build fails due to a compilation error in cucumber-core:

[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/cucumber/cucumber-jvm/core/src/main/java/cucumber/runtime/formatter/JSONFormatter.java:[253,51] cannot find symbol
symbol: method getContentType()
location: variable docString of type gherkin.pickles.PickleString

[rjwittams]

I'm not sure if this is an automatic reply. It fails because the cucumber mono repo needs to apply its PR before this will work, as stated above. I didn't want to mess about with the versions in pom.xml before it made sense.

[mpkorstanje]

I'd suggest should_format_scenario_with_a_step_with_a_doc_string_and_content_type

[rjwittams]

Sorry, I did have it at that name before, but was fighting with the json pretty formatter, and recreated the method a few times. Will update.

…

On 22 Oct 2017, at 12:37, M.P. Korstanje ***@***.***> wrote: @mpkorstanje commented on this pull request. In core/src/test/java/cucumber/runtime/formatter/JSONFormatterTest.java <#1265 (comment)>: > @@ -678,6 +678,68 @@ public void should_format_scenario_with_a_step_with_a_doc_string() throws Throwa } @test + public void should_format_scenario_with_a_step_with_a_doc_string2() throws Throwable { I'd suggest should_format_scenario_with_a_step_with_a_doc_string_and_content_type — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1265 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAt6CZu5TOxEjZdoiTO-hVtUrohk2jY6ks5suyjugaJpZM4QB5fI>.

[mlvandijk]

@rjwittams Not a bot ;) Sorry, I missed your comment about the PRs being related.

[brasmusson]

Should cucumber/common#292 be accepted and the content type of doc strings be included in the Pickles, then it is convenient for the Json Formatter to get in from the Pickle, until then #1309 is fixing the regression from v1.x.x so that the content type is included in the Json Formatter output.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

[stale]

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

[brasmusson]

cucumber/common#292 has been accepted, now we just have to wait for a Gherkin release before this PR can be merged.

[aslakhellesoy]

Hi @rjwittams,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.