Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Print root cause of exceptions in glue definition #1873

Merged
merged 2 commits into from
Jan 26, 2020
Merged

[Core] Print root cause of exceptions in glue definition #1873

merged 2 commits into from
Jan 26, 2020

Conversation

mpkorstanje
Copy link
Contributor

Summary

Exceptions thrown by parameter, datatable and docstring definitions
are swallowed leaving a stack trace ending with a rather puzzling
CucumberInvocationTargetException.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mpkorstanje
[Core] Print root cause of glue definitions
e455510 
Exceptions thrown by parameter, datatable and docstring definitions
are swallowed leaving a stack trace ending with a rather puzzling
`CucumberInvocationTargetException`.
@mpkorstanje mpkorstanje added this to the 5.x.x milestone Jan 26, 2020
@coveralls
Copy link

coveralls commented Jan 26, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 87.895% when pulling 686c1ea on rethrow-exceptions-from-type-glue into 871adb5 on master.

@mpkorstanje mpkorstanje changed the title [Core] Print root cause of glue definitions [Core] Print root cause of exceptions in glue definition Jan 26, 2020
@mpkorstanje mpkorstanje merged commit 940d756 into master Jan 26, 2020
@mpkorstanje mpkorstanje deleted the rethrow-exceptions-from-type-glue branch January 26, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.x.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mpkorstanje @coveralls