Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java8] Show error message when used on Java 12+ #1902

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

mpkorstanje
Copy link
Contributor

Summary

Because of #1817 cucumber-java8 can't resolve the argument types of step definitions, parameter types and data table types. This results in a number of rather obscure behaviours. By adding a clear error message can avoid these behaviours.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

@mpkorstanje mpkorstanje changed the title [Java8] Add error when types could not be resolved on Java 12+ [Java8] Provide clear error when used on Java 12+ Feb 27, 2020
@mpkorstanje mpkorstanje changed the title [Java8] Provide clear error when used on Java 12+ [Java8] Show error message when used on Java 12+ Feb 27, 2020
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.004%) to 83.015% when pulling e1fd6f5 on improve-error-message-on-jdk12 into 0386fe7 on master.

@mpkorstanje mpkorstanje merged commit f96edc6 into master Feb 27, 2020
@mpkorstanje mpkorstanje deleted the improve-error-message-on-jdk12 branch February 27, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants