Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cdi2] Correctly cast the UnmanagedInstance values #2244

Merged
merged 7 commits into from
Feb 27, 2021

Conversation

dcendents
Copy link
Contributor

Fixes #2242

Added a test first to reproduce the problem along with an exclusion in beans.xml to force the Step class to be loaded as an UnmanagedInstance.

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #2244 (d88505e) into main (873cd45) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2244      +/-   ##
============================================
+ Coverage     82.97%   82.98%   +0.01%     
  Complexity     2339     2339              
============================================
  Files           307      307              
  Lines          8324     8324              
  Branches        768      768              
============================================
+ Hits           6907     6908       +1     
  Misses         1111     1111              
+ Partials        306      305       -1     
Impacted Files Coverage Δ Complexity Δ
...i2/src/main/java/io/cucumber/cdi2/Cdi2Factory.java 96.96% <100.00%> (+6.06%) 10.00 <3.00> (+1.00)
...main/java/io/cucumber/java/JavaHookDefinition.java 92.59% <0.00%> (-3.71%) 9.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 873cd45...837d4c8. Read the comment docs.

@mpkorstanje mpkorstanje changed the title correctly cast the UnmanagedInstance value [CDI2] Correctly cast the UnmanagedInstance values Feb 26, 2021
@mpkorstanje mpkorstanje changed the title [CDI2] Correctly cast the UnmanagedInstance values [Cdi2] Correctly cast the UnmanagedInstance values Feb 26, 2021
@mpkorstanje mpkorstanje merged commit 95dddd5 into cucumber:main Feb 27, 2021
@aslakhellesoy
Copy link
Contributor

Hi @dcendents,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

@dcendents
Copy link
Contributor Author

@aslakhellesoy Thanks, this is unexpected and a very open way to make open source projects. I'll join the slack channel and introduce myself.

This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cucumber-cdi2 ClassCastException on unmanaged instances
4 participants