[Core] Mark pending steps as failed in teamcity plugin #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
team-city-plugin-should-mark-pending-steps-as-failed
branch
from
d81097e
to
89cb162
Compare
mpkorstanje
changed the title
mpkorstanje
force-pushed
the
team-city-plugin-should-mark-pending-steps-as-failed
branch
from
89cb162
to
c1aa4ad
Compare
Codecov Report
@@ Coverage Diff @@
## main #2264 +/- ##
============================================
+ Coverage 83.10% 83.19% +0.08%
- Complexity 2352 2354 +2
============================================
Files 307 307
Lines 8370 8373 +3
Branches 770 770
============================================
+ Hits 6956 6966 +10
+ Misses 1110 1103 -7
Partials 304 304
Continue to review full report at Codecov.
|
The teamcity plugin communicates test results to IntelliJ IDEA using teamcity service messages[1]. Currently the teamcity plugin marks pending steps as skipped rather then failed. This is inconsistent with the changes from #1960 in which pending steps are considered a test failure. 1: https://www.jetbrains.com/help/teamcity/service-messages.html
mpkorstanje
force-pushed
the
team-city-plugin-should-mark-pending-steps-as-failed
branch
from
c1aa4ad
to
8b7ca64
Compare
mpkorstanje
deleted the
team-city-plugin-should-mark-pending-steps-as-failed
branch
This was referenced Mar 15, 2021
Merged
Merged
This was referenced Mar 16, 2021
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The teamcity plugin communicates test results to IntelliJ IDEA using teamcity
service messages[1]. Currently the teamcity plugin marks pending steps as
skipped rather then failed. This is inconsistent with the changes from #1960
in which pending steps are considered a test failure.
1: https://www.jetbrains.com/help/teamcity/service-messages.html