Resolved #241 - Slow spring context performance #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed child spring context and implemented custom scope for glue code. cucumber-glue.xml is internal now. All context configuration may be done in cucumber.xml
|
Looks great. I'll merge this after @TeDDaN or @hutchy2570 have confirmed that this fixes their speed regression. |
|
I can confirm this has fixed the speed issue we've been seeing (in fact it's faster than RC15). Good work! |
aslakhellesoy
added a commit
that referenced
this pull request
Mar 5, 2012
hutchy2570
pushed a commit
to lgi-kitd/cucumber-jvm
that referenced
this pull request
Mar 21, 2012
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #241 - Slow spring context performance
Removed child spring context and implemented custom scope for glue code.
cucumber-glue.xml is internal now. All context configuration may be done in cucumber.xml