Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependency com.google.inject:guice to v5.1.0 #2473

Merged
merged 2 commits into from
Jan 30, 2022
Merged

Update dependency com.google.inject:guice to v5.1.0 #2473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4684970
Update dependency com.google.inject:guice to v5.1.0
renovate-bot Jan 30, 2022
2f64ae2
Ignore changes to guice api
mpkorstanje Jan 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 27 additions & 1 deletion .revapi/api-changes.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@
"new": "missing-class com.google.inject.Stage",
"justification": "Guice is an optional TestNG dependency"
},

{
"ignore": true,
"code": "java.method.removed",
Expand Down Expand Up @@ -237,5 +236,32 @@
]
}
}
],
"guice": [
{
"extension": "revapi.differences",
"id": "guice-api-issues",
"ignore": true,
"configuration": {
"differences": [
{
"ignore": true,
"code": "java.annotation.added",
"old": "class com.google.inject.Key<T>",
"new": "class com.google.inject.Key<T>",
"annotation": "@com.google.errorprone.annotations.CheckReturnValue",
"justification": "It's Google."
},
{
"ignore": true,
"regex": true,
"code": "java.field.enumConstantOrderChanged",
"old": "field com\\.google\\.inject\\.internal\\.ErrorId\\..*",
"new": "field com\\.google\\.inject\\.internal\\.ErrorId\\..*",
"justification": "It's Google."
}
]
}
}
]
}
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
* Update dependency io.cucumber:ci-environment to v9 ([#2475](https://github.com/cucumber/cucumber-jvm/pull/2475) M.P. Korstanje)
* Update dependency io.cucumber:html-formatter to v18 ([#2476](https://github.com/cucumber/cucumber-jvm/pull/2476) M.P. Korstanje)
- Removed work around for 'Uncaught TypeError: e.git is undefined'
* Update dependency com.google.inject:guice to v5.1.0 ([#2473](https://github.com/cucumber/cucumber-jvm/pull/2473) M.P. Korstanje)
* Update dependency org.testng:testng to v7.5 ([#2457](https://github.com/cucumber/cucumber-jvm/pull/2457) M.P. Korstanje)

### Deprecated

Expand Down
2 changes: 1 addition & 1 deletion guice/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<properties>
<apiguardian-api.version>1.1.2</apiguardian-api.version>
<guice.version>5.0.1</guice.version>
<guice.version>5.1.0</guice.version>
<hamcrest.version>2.2</hamcrest.version>
<junit-jupiter.version>5.8.2</junit-jupiter.version>
<project.Automatic-Module-Name>io.cucumber.guice</project.Automatic-Module-Name>
Expand Down
4 changes: 4 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,6 +376,9 @@
<revapi.differences id="testng-api-issues">
<ignore>true</ignore>
</revapi.differences>
<revapi.differences id="guice-api-issues">
<ignore>true</ignore>
</revapi.differences>
</analysisConfiguration>
<analysisConfigurationFiles>
<configurationFile>
Expand All @@ -385,6 +388,7 @@
<root>7.2.0</root>
<root>internal</root>
<root>testng</root>
<root>guice</root>
</roots>
</configurationFile>
</analysisConfigurationFiles>
Expand Down