Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TestNG] Remove spurious Optional[<Feature Name>] from test name #2488

Merged
merged 1 commit into from
Feb 17, 2022
Merged

[TestNG] Remove spurious Optional[<Feature Name>] from test name #2488

merged 1 commit into from
Feb 17, 2022

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Feb 16, 2022 •
edited
Loading

When executing tests, the test name would be displayed as:

RunCucumberTest.runScenario["Another Addition", "Optional[Basic Arithmetic]"]

Which should have been:

RunCucumberTest.runScenario["Another Addition", "Basic Arithmetic"]

@mpkorstanje mpkorstanje marked this pull request as ready for review February 16, 2022 23:32
@codecov
Copy link

codecov bot commented Feb 16, 2022 •
edited
Loading

Codecov Report

Merging #2488 (1c25dd3) into main (65dfc97) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##               main    #2488   +/-   ##
=========================================
  Coverage     83.70%   83.70%           
  Complexity     2677     2677           
=========================================
  Files           319      319           
  Lines          9438     9438           
  Branches        916      916           
=========================================
  Hits           7900     7900           
  Misses         1201     1201           
  Partials        337      337
Impacted Files Coverage Δ
...in/java/io/cucumber/testng/FeatureWrapperImpl.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65dfc97...1c25dd3. Read the comment docs.

@mpkorstanje mpkorstanje force-pushed the fix-testng-display-name branch 2 times, most recently from fd80c13 to 0a9cdcd Compare February 16, 2022 23:55
@mpkorstanje
[TestNG] Remove spurious Optional[<Feature Name>] from test name
1c25dd3 
When executing tests, the test name would be displayed as:

```
RunCucumberTest.runScenario["Another Addition", "Optional[Basic Arithmetic]"]
```

Which should have been:

```
RunCucumberTest.runScenario["Many additions", "Basic Arithmetic"]
```
@mpkorstanje mpkorstanje merged commit 3c2d29d into main Feb 17, 2022
@mpkorstanje mpkorstanje deleted the fix-testng-display-name branch February 17, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpkorstanje