-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Use null safe-messages #2497
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
main
branch
3 times, most recently
from
March 20, 2022 01:13
b85ab35
to
4e688d1
Compare
mpkorstanje
commented
Apr 3, 2022
Codecov Report
@@ Coverage Diff @@
## main #2497 +/- ##
============================================
+ Coverage 83.80% 84.40% +0.60%
+ Complexity 2651 2648 -3
============================================
Files 309 310 +1
Lines 9360 9324 -36
Branches 913 896 -17
============================================
+ Hits 7844 7870 +26
+ Misses 1183 1121 -62
Partials 333 333
Continue to review full report at Codecov.
|
Very nice!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cucumber/common#1879
messages
now usesOptional<T>
for optional types avoiding some unexpected null references.This resulted in some updating of
gherkin
andhtml-formatter
.Additionally with this change the dependency on Jackson has been removed from
messages
. However we still have to serialize the message objects into json.So for now Jackson is shaded into
core
instead. And eventually we'll be ableto spin this out to it's own module.