Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Cleanly stop after failure to start application context #2570

Merged
merged 1 commit into from
Jun 19, 2022

Conversation

mpkorstanje
Copy link
Contributor

πŸ€” What's changed?

Fixes: #2569

🏷️ What kind of change is this?

  • πŸ› Bug fix (non-breaking change which fixes a defect)

πŸ“‹ Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@mpkorstanje mpkorstanje force-pushed the 2569-stop-context-after-failure-to-start branch from 5be7768 to 134f910 Compare June 13, 2022 17:41
@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #2570 (eafe0f0) into main (2764068) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #2570      +/-   ##
============================================
+ Coverage     84.54%   84.58%   +0.04%     
- Complexity     2661     2664       +3     
============================================
  Files           310      310              
  Lines          9356     9357       +1     
  Branches        901      901              
============================================
+ Hits           7910     7915       +5     
+ Misses         1115     1111       -4     
  Partials        331      331              
Impacted Files Coverage Ξ”
...n/java/io/cucumber/spring/CucumberTestContext.java 71.87% <100.00%> (+0.90%) ⬆️
...in/java/io/cucumber/spring/TestContextAdaptor.java 92.85% <100.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 2764068...eafe0f0. Read the comment docs.

@mpkorstanje mpkorstanje force-pushed the 2569-stop-context-after-failure-to-start branch from 134f910 to 30a291f Compare June 13, 2022 17:47
@mpkorstanje mpkorstanje force-pushed the 2569-stop-context-after-failure-to-start branch from 30a291f to 9ba6b9e Compare June 19, 2022 16:52
@mpkorstanje mpkorstanje force-pushed the 2569-stop-context-after-failure-to-start branch from 9ba6b9e to eafe0f0 Compare June 19, 2022 17:25
@mpkorstanje mpkorstanje merged commit 0ee15f0 into main Jun 19, 2022
@mpkorstanje mpkorstanje deleted the 2569-stop-context-after-failure-to-start branch June 19, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Cucumber with @FlywayTest, generates "Scope 'cucumber-glue' is not active for the current thread"
1 participant