Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressing Issue#263: Eclipse JUnit reports inaccurate run count #274

Merged
merged 1 commit into from
Mar 23, 2012
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion junit/src/main/java/cucumber/junit/JUnitReporter.java
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ public void finishExecutionUnit() {
public void match(Match match) {
Description description = executionUnitRunner.describeChild(steps.remove(0));
stepNotifier = new EachTestNotifier(runNotifier, description);
stepNotifier.fireTestStarted();
reporter.match(match);
}

Expand All @@ -71,6 +70,8 @@ public void result(Result result) {
stepNotifier.fireTestIgnored();
} else {
if (stepNotifier != null) {
//Should only fireTestStarted if not ignored
stepNotifier.fireTestStarted();
if (error != null) {
stepNotifier.addFailure(error);
}
Expand Down