[Pico] Fixed missing calls to start, stop and dispose handles #2772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Corrected the pico-container lifecycle: the start, stop and dispose methods are now called for every test scenarios.
The code is the same as before #2725 (so it's safer in terms of lifecycle), except that the pico container is recycled in the
start()
method when it already exists.When a second call to
start()
is done (e.g. for the 2nd scenario), the container component instances are all in disposed state and the container lifecycle is in disposed state. The recycling operation consists in removing all container component instances (i.e. flushing the cache) and resetting the container lifecycle.⚡️ What's your motivation?
Fixes #2771
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I tested the new version on a project with ~480 test scenarios and saw no performance difference when compared to Cucumber 7.12.0.
📋 Checklist: