Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix of Embedded data failure to display in HTML reports #423

Closed
wants to merge 1 commit into from
Closed

fix of Embedded data failure to display in HTML reports #423

wants to merge 1 commit into from

Conversation

tsuhachev
Copy link

fix for #412

@aslakhellesoy
Copy link
Contributor

Thanks!

@thestumonkey
Copy link

When are you intending on merging this in and releasing a new version? Have been trying to compile myself to incorporate this fix (and the JSON results one) with limited success.

@aslakhellesoy
Copy link
Contributor

@thestumonkey when I get a break from the rest of my life. When is unknown.

@aslakhellesoy
Copy link
Contributor

I wasn't happy with this fix. No tests and it was just working around the problem rather than fixing it. I implemented a better fix in 60bf05b

@tsuhachev
Copy link
Author

I doubt I could fix better than you did :) maybe I could have done that if I had had the clue from you
thanks anyway

@aslakhellesoy
Copy link
Contributor

@tsuhachev I didn't really have a clue until I started looking closer, but your fix put me on the right track, so it was indeed helpful :-)

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants