Patch for issue #322 #445
Closed
Patch for issue #322 #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 3, 2013 11:34
…thod in DescriptionFactory and made some classes Serializable
|
Merged! |
aslakhellesoy
added a commit
that referenced
this pull request
Jan 13, 2013
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that JUnit 4.11 has been released, here's a patch for issue #322. The changes in this patch have been used (against a previous, forked, version of Cucumber-JVM) in our builds for a few months now.
For me, a question mark is whether there is still a need for the DescriptionFactory class, or if that could be deprecated in favour of a straight use of the right Description.createSuiteDescription method from JUnit.