Proposed solution to #487 (International keywords build problems)

[aslakhellesoy]

This proposed fix for #487 changes generated java annotations from top level classes to inner classes. This is to work around difficulties with java source files with names containing multibyte characters on OS X.

Prior to this PR, the Swedish translation for Then would be a top level class defined in Så.java, under the package cucumber.api.java.sv.

This PR changes each translation to be defined in a single source file, in this case sv.java defined under the package cucumber.api.java. Each translation contains an inner class for each keyword.

This should remain source compatible with previous releases. The following import statement should work both before and after:

import cucumber.api.java.sv.Så;

Using this scheme, source file names will only ever contain ASCII characters, so the file name problems should go away.

One minor drawback is that typing @Så in IDEA and then using a hotkey to insert the desired import will write out this code:

import cucumber.api.java.sv;

public class Stepdefs {
    @sv.Så("test")
    public void testEncoding() {

    }
}

Although this compiles just fine it doesn't look too good, so you might want to change it to:

import cucumber.api.java.sv.*;

public class Stepdefs {
    @Så("test")
    public void testEncoding() {

    }
}

Please try this out and let me know how it works for you.

[aslakhellesoy]

/cc @avokin @klikh - please let me know if this affects IDEA.

[avokin]

I'll take a look, thank you for info

[dkowis]

Been two months without comment. I don't think having to manually update the stuff in IDEA is a big deal.

I'm fine with merging this as it is. @avokin, @klikh dissenting opinions?

[aslakhellesoy]

I'm not sure this actually fixes anything. I prefer to do some more testing on a mac before this is merged. I've assigned this issue to myself.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.