Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output embedded text in HTML report #501

Closed
wants to merge 1 commit into from

Conversation

tomdcc
Copy link
Contributor

@tomdcc tomdcc commented Apr 8, 2013

The formatter in cucumber-html already supports embedding content
with mime-types starting with "text/" into the HTML report -
this just makes cucumber-jvm not swallow the text content before
it gets that far.

The formatter in cucumber-html already supports embedding content
with mime-types starting with "text/" into the HTML report -
this just makes cucumber-jvm not swallow the text content before
it gets that far.
@aslakhellesoy
Copy link
Contributor

LGTM!

@aslakhellesoy
Copy link
Contributor

Now that I have thought about this, I actually think we should instead throw an exception in embed if the mimeType starts with "text/". The exception should contain a hint about using the write method instead.

WDYT?

@tomdcc
Copy link
Contributor Author

tomdcc commented Apr 8, 2013

Oh yeah, I didn't even see the write method! Hmm. That works for my case, but I wonder if there's a broader case for being able to embed files of whatever type people want, and just linking to them rather than displaying them inline in the html? We might want to allow some sort of customisable filename or link text if we do that though... thoughts?

@tomdcc
Copy link
Contributor Author

tomdcc commented Apr 8, 2013

So the idea would be that for video / images we could display inline, and anything else we'd just link to to allow someone to download it or whatever their browser wants to do with it.

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants