Let the JUnitFormatter mark skipped tests as failures in strict mode #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the option strict make JUnitFormatter to mark skipped tests as failures. Use a new interface StrictAware to determine which formatters the strict option should be passed to, following the example of the interface ColorAware determining which formatters the monochrome option is sent to.
|
That was quick! I had to restart the travis build, but it looks good to me. @lucas1000001 can you merge this one in? Aslak |
ghost
assigned 
|
Sure will do. |
notmattlucas
added a commit
that referenced
this pull request
Jun 13, 2013
Let the JUnitFormatter mark skipped tests as failures in strict mode
|
Built and tested fine locally - merged in. |
|
@lucas1000001 thanks - don't forget to update History.md |
notmattlucas
added a commit
that referenced
this pull request
Jun 13, 2013
|
Oops, sorry, done :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the option strict make the JUnitFormatter to mark skipped tests as failures.
Use a new interface StrictAware to determine which formatters the strict option should be passed to, following the example of the interface ColorAware determining which formatters the monochrome option is sent to.