JUnitFormatter: Fix indentation, hook handling and support all-steps-first execution #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To aid testing, make it possible to inject a glue when creating a Runtime. Also add a test specify that a CucumberException is thrown if no backends are found (or an emtpy collection of backends is injected).
Adjust the number of . separating the step text from the step result, so that the results are aligned.
The main issue is that the JUnitFormatter does not handle failures in the before and after hooks properly. To add flexibility the tests also specify that the JUnitFormatter should handle both all-steps-first execution and one-step-at-the-time execution.
Change the JUnitFormatter to handle failures in the before and after hooks properly. Also change the JUnitFormatter to handle both all-steps-first execution and one-step-at-the-time execution.
|
LGTM! |
brasmusson
added a commit
that referenced
this pull request
Jul 16, 2013
Merge pull request #556 JUnitFormatter: Fix indentation, hook handling and support all-steps-first execution. Update the History.md
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the number of . separating the step text from the step result, so that the results are aligned.
Change the JUnitFormatter to handle failures in the before and after hooks properly.
Also change the JUnitFormatter to handle both all-steps-first execution and one-step-at-the-time execution.