Use uri instead of path in CucumberFeature #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows paths use '\' as separator, but uri:s use '/'. On other platforms both paths and uri:s use '/' as separator. Make sure that paths are converted to uri:s when CucumberFeatures are created.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the JSONPrettyFormatter failure on Windows, I originally thought; "Since Cucumber-JVM both on Windows and *nix support '/' in feature path arguments on the command line and Cucumber.Options, why not use '/' in the URI sent to formatters on all platforms?"
Reading up on URI:s revealed that URI:s always use '/' on all platforms, it is only file paths that on Windows use '' (http://stackoverflow.com/questions/1589930/so-what-is-the-right-direction-of-the-paths-slash-or-under-windows, http://blogs.msdn.com/b/ie/archive/2006/12/06/file-uris-in-windows.aspx)
Therefore make sure to the featureURI argument sent to the Gherkin parser when creating CucumberFeature is an URI using '/' and not a file path (which on Windows uses '').
This PR has been tested successfully (mvn clean package) on both:
Windows XP
Ubuntu 13.04