The RerunFormatter does not handle failures in background and scenario outline examples correctly #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add failing tests for the handling of failures in background, scenario outline examples and hooks in the RerunFormatter. Move helpers to test formatters to TestHelper.
Fix the rerun formatters handling of failures in background, scenario outline examples and hooks in the RerunFormatter. Move all testing of the RerunFormatter to core.
Move helpers from CucumberPrettyFormatterTest to TestHelper, and refactor to make the helper share implementation in TestHelper.
Simplify the RerunFormatter by taking advantage of the new methods startOfScenarioLifeCycle and endOfScenarioLifeCycle in the Formatter interface.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RerunFormatter does not handle failures in background and scenario outline examples correctly. The use of the line of the failed step works ok in case of ordinary scenarios, but to handle failures in background steps, in examples in scenario outlines and in hooks the line of the scenario needs to be used.