Using spring @ContextHierarchy to manage multiple @ContextConfiguration's breaks with 1.1.5

[martinlau]

The new version of SpringFactory includes the code:

    private boolean dependsOnSpringContext(Class<?> type) {
        return type.isAnnotationPresent(ContextConfiguration.class);
    }

This should probably be extended to:

    private boolean dependsOnSpringContext(Class<?> type) {
        return type.isAnnotationPresent(ContextConfiguration.class)
            || type.isAnnotationPresent(ContextHierarchy.class);
    }

[aslakhellesoy]

Can you send a pull request with a test for this please?

[aslakhellesoy]

@ffbit I've assigned this one to you. If you're busy, can you pass it on to @pasviegas please?

[pasviegas]

Hey Aslak, I can do that! I'll look into it on monday!

Thanks, Pedro

On Oct 13, 2013, at 2:44 AM, Aslak Hellesøy notifications@github.com wrote:

@ffbit I've assigned this one to you. If you're busy, can you pass it on to @pasviegas please?

—
Reply to this email directly or view it on GitHub.

[pasviegas]

Yeah @aslakhellesoy that's is exactly what is happening. The pr seems good for me.

[aslakhellesoy]

Thanks @pasviegas - can you merge it to master and update History.md please?

[ffbit]

Great job, @martinlau!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

[aslakhellesoy]

Hi @martinlau,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

• ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
• 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
• 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
• ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
• 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber