Log a warning when more than one IoC dependency is found in the classpath

[arikogan]

It has happened to us that people put more than one IoC dependency into their classpath (e.g. cucumber-spring AND cucumber-guice) and suddenly their beans are not being wired correctly. This is because when Cucumber detects such situation it silently defaults to DefaultJavaObjectFactory which doesn't provide IoC features.

This pull request adds a warning so at least this situation can be spotted while reading the log.

[aslakhellesoy]

Please remove slf4j and replace the logging with a simple System.err.println.

[arikogan]

Well spotted, thanks for that. Please let me know if you are ok with the changes.

[aslakhellesoy]

Thanks, that works, but I think it would be even better if you added two exception classes - NoInstances and TooManyInstances. And then a catch block for each one. It's a little ghetto to look at the exception's message to separate the two cases ;-)

[arikogan]

I absolutely agree with you. I only did it because, based on what I've seen, there is not a hierarchy under CucumberException, only two classes extend it. Happy do it though, it's much more elegant.

[arikogan]

Hi Aslak. Have you had the chance to look at this? Thanks.

[aslakhellesoy]

Hi Ariel - not yet, but it looks good. @ilanpillemer could you merge this in please?

[brasmusson]

Merged. Thanks for your effort @arikogan.

[brasmusson]

@aslakhellesoy @ilanpillemer I took me the liberty to merge this PR.

[aslakhellesoy]

Thanks @brasmusson

@ilanpillemer still want to be part of the team?

[arikogan]

Thanks very much @brasmusson and @aslakhellesoy.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.