Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for DataTable as parameter in Jython steps #602

Merged
merged 4 commits into from
Oct 12, 2013
Merged

Fix for DataTable as parameter in Jython steps #602

merged 4 commits into from
Oct 12, 2013

Conversation

lggroapa
Copy link
Contributor

@lggroapa lggroapa commented Oct 8, 2013

If the argument is a DataTable it is converted to the raw form (List<List) then converted to PyArray so you can pass it as a PyObject

If the argument is a DataTable it is converted to the raw form (List<List<String>) then converted to PyArray so you can pass it as a PyObject
@aslakhellesoy
Copy link
Contributor

Can you add a test please?

@aslakhellesoy
Copy link
Contributor

Also, please follow coding conventions (4 space indent). See CONTRIBUTING.md

@lggroapa
Copy link
Contributor Author

lggroapa commented Oct 8, 2013

Ok i will try to add a test, and ill change to respect the convention, but tomorrow ;)

@aslakhellesoy
Copy link
Contributor

@lggroapa
Copy link
Contributor Author

Ok added tests and i hope i did the formatting good, sorry about me being slow but the proxy i have dosen't work well with git client so i had to do the commits from browser :)

@aslakhellesoy
Copy link
Contributor

Thanks @lggroapa. Your tests didn't assert anything, so they weren't really tests ;-)

I added some assertions and realised there was a bug in your code - we have to use PyList instead of PyArray.

Thanks for your contribution!

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants