-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for DataTable as parameter in Jython steps #602
Conversation
If the argument is a DataTable it is converted to the raw form (List<List<String>) then converted to PyArray so you can pass it as a PyObject
Can you add a test please? |
Also, please follow coding conventions (4 space indent). See CONTRIBUTING.md |
Ok i will try to add a test, and ill change to respect the convention, but tomorrow ;) |
Cool, just modify the stuff in here: https://github.com/cucumber/cucumber-jvm/tree/master/jython/src/test/resources/cucumber/runtime/jython |
Ok added tests and i hope i did the formatting good, sorry about me being slow but the proxy i have dosen't work well with git client so i had to do the commits from browser :) |
Thanks @lggroapa. Your tests didn't assert anything, so they weren't really tests ;-) I added some assertions and realised there was a bug in your code - we have to use Thanks for your contribution! |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
If the argument is a DataTable it is converted to the raw form (List<List) then converted to PyArray so you can pass it as a PyObject