Allow TestNG Cucumber runner to use composition instead of inheritance #622

martykube · 2013-11-05T19:21:41Z

Right now to use the TestNG runner you need to inherit from AbstractTestNGCucumberTests. I'm working on a large existing project where we have a base test class that does a lot of framework setup. The only solution I had was to copy AbstractTestNGCucumberTests into my project and modify it to inherit from our base class.

This patch removes the need to inherit from AbstractTestNGCucumberTests. You can still do so if you want.

…umberTests

ffbit · 2013-11-05T22:55:30Z

@martykube great job!
That's TestNG day has come!
I've run your code code and had a look at the test report of the java-calculator-testng test project.
And I found your idea and code brilliant.
I'll merge it in a couple of days, if there no comments/questions/suggestions on your code.

off topic
I can see that TestNG becomes more and more popular.
Could you, please, provide a couple of good links or books to read on TestNG?
Thanks in advance.

Have a good day.

martykube · 2013-11-06T01:50:23Z

@ffbit Thanks for the positive feedback! I'll keep an eye out for comments/questions.suggestions.

I am sorry to say I don't have any recommendations yet on TestNG reading. This is my first encounter with TestNG... I was asked to add Cucumber to an existing Selenium framework. The framework uses TestNG so here I am :-)

I do want to add a some code examples, maybe at examples/java-calculator-testng/README.md. That might make it easier for folks to pick up Cucumber + TestNG.

ffbit · 2013-11-08T22:44:18Z

testng/src/main/java/cucumber/api/testng/AbstractTestNGCucumberTests.java

@@ -17,28 +17,10 @@
 import java.io.IOException;


There are some unused imports left. Could you please remove them?

ffbit · 2013-11-08T22:50:21Z

@martykube great job, yet again!
I'm looking forward to you changes or reasons not to do them.
Have a nice day.

brasmusson · 2013-11-09T14:52:07Z

testng/src/main/java/cucumber/api/testng/TestNGCucumberRunner.java

+        // remove duplicates from glue path.
+        List<String> uniqueGlue = new ArrayList<String>(new HashSet<String>(runtimeOptions.getGlue()));
+        runtimeOptions.getGlue().clear();
+        runtimeOptions.getGlue().addAll(uniqueGlue);


@martykube I reckon that you got trouble when the glue paths was not unique. Maybe it would be better if the RuntimeOptions itself should make sure that the glue paths were unique. I don't say that this should be done in this pull request, but it is something that maybe should be done as an improvement later.

@brasmusson Uniqueness of glue paths is provided by line 37.

@ffbit Now I do not follow. I can see that line 37-39 makes the glue paths unique. The thing is that one part of me says that that code does not belong here, because uniques of glue paths is not something that is important just for a TestNG runner, is it? But if it is important that the glue paths are unique (regardless of running from command line, using the JUnit runner, using the TestNG runner, etc), shouldn't it be the RuntimeOptions class responsibility to make sure that the glue paths are unique?

@brasmusson I totally agree with you.
I think we should go much deeper to provide uniqueness of discovered classes with step definitions.
And, as you mentioned, there should be another PR on this problem.

@brasmusson thanks for your finding and I'm sorry for my bad previous comment.

Just to summarise my view on the code in lines 37-39.
It's a hack, but it's a forced one. Let's let it go and fix its roots later.

The trouble I had was that RuntimeOptions created duplicate entries due to the test class and the super class being in the same package. Then the test case failed due to duplicate step definitions being found during the second scan of the duplicate glue path.

I agree that this should be pushed down into RuntimeOptions.

This pull request needs the duplicate elimination. We could either 1) fix RuntimeOptions and remove the code in this pull request, or 2) Leave this patch as is and add duplicate elimination to RuntimeOptions in another pull request. Let me know what makes sense.

The second option is good in my view.

martykube · 2013-11-09T20:37:21Z

@ffbit Your suggestions are good, I'll make the changes.
Two comments were for empty line removal - I'm not sure which line is the offender. Let me know, Thanks!

ffbit · 2013-11-10T10:24:23Z

@martykube I've just sent you a pull request with those empty lines removed. Please check it out in your own forked repo.

martykube · 2013-11-11T19:54:16Z

@ffibit got the pull for the empty lines. I'm working on the other comments and should have that finished shortly

ffbit · 2013-11-11T21:29:15Z

You can merge my commit and it will appear in this thread, if you want.
Just to clarify, please do not implement glue merging in this PR - it's out of scope.

11.11.2013, 23:54, "Marty Kube" notifications@github.com:

@ffibit got the pull for the empty lines. I'm working on the other comments and should have that finished shortly

—
Reply to this email directly or view it on GitHub.

martykube · 2013-11-11T22:26:51Z

@ffibit I've added a commit to address the comments. Let me know if there is anything else needed to allow a merge.

I was thinking about updating RuntimeOptions to make the glue paths unique.

martykube · 2013-11-12T02:09:37Z

@ffbit Your commit is in. No glue merging here :-)

I'm "hands off" on this pull request unless there are other comments,

Allow TestNG Cucumber runner to use composition instead of inheritance

ffbit · 2013-11-12T15:15:34Z

@martykube
Great job!

History.md update on #622

Relates to #608, #622, #632 issues.

lock · 2018-10-25T09:27:45Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

aslakhellesoy · 2018-10-25T09:27:47Z

Hi @martykube,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

aslakhellesoy · 2018-10-25T09:27:47Z

Hi @martykube,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Allow TestNG test cases to not have to inherit from AbstractTestNGCuc…

f27890e

…umberTests

ghost assigned ffbit Nov 5, 2013

ffbit reviewed Nov 8, 2013
View reviewed changes

brasmusson reviewed Nov 9, 2013
View reviewed changes

brasmusson mentioned this pull request Nov 10, 2013

Support for RuntimeOptions.merge and multiple @CucumberOptions #608

Closed

Removed 2 empty lines in the c.a.t.TestNGCucumberRunner class

b11a8bf

Address pull request comments

c4d27b4

ffbit pushed a commit that referenced this pull request Nov 12, 2013

Merge pull request #622 from martykube/master

cca52ae

Allow TestNG Cucumber runner to use composition instead of inheritance

ffbit merged commit cca52ae into cucumber:master Nov 12, 2013

ffbit mentioned this pull request Nov 12, 2013

History.md update on #622 #629

Merged

ffbit pushed a commit that referenced this pull request Nov 12, 2013

Merge pull request #629 from ffbit/622_history_update

d89ca5a

History.md update on #622

martykube mentioned this pull request Nov 14, 2013

Prevent duplicate glue paths #632

Closed

ffbit pushed a commit that referenced this pull request Nov 14, 2013

Fix duplicated step definitions from the same step locations

7eb57b3

Relates to #608, #622, #632 issues.

ffbit mentioned this pull request Nov 14, 2013

Fix duplicated step definitions from the same step locations #633

Closed

brasmusson mentioned this pull request Jan 10, 2014

AbstractTestNGCucumberTests runs each feature as separate test #653

Closed

lock bot unassigned ffbit Oct 25, 2018

lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow TestNG Cucumber runner to use composition instead of inheritance #622

Allow TestNG Cucumber runner to use composition instead of inheritance #622

martykube commented Nov 5, 2013

ffbit commented Nov 5, 2013

martykube commented Nov 6, 2013

ffbit Nov 8, 2013

martykube Nov 9, 2013

ffbit commented Nov 8, 2013

brasmusson Nov 9, 2013

ffbit Nov 9, 2013

brasmusson Nov 9, 2013

ffbit Nov 9, 2013

ffbit Nov 9, 2013

martykube Nov 9, 2013

ffbit Nov 9, 2013

martykube commented Nov 9, 2013

ffbit commented Nov 10, 2013

martykube commented Nov 11, 2013

ffbit commented Nov 11, 2013

martykube commented Nov 11, 2013

martykube commented Nov 12, 2013

ffbit commented Nov 12, 2013

lock bot commented Oct 25, 2018

aslakhellesoy commented Oct 25, 2018

aslakhellesoy commented Oct 25, 2018

Allow TestNG Cucumber runner to use composition instead of inheritance #622

Allow TestNG Cucumber runner to use composition instead of inheritance #622

Conversation

martykube commented Nov 5, 2013

ffbit commented Nov 5, 2013

martykube commented Nov 6, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ffbit commented Nov 8, 2013

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

martykube commented Nov 9, 2013

ffbit commented Nov 10, 2013

martykube commented Nov 11, 2013

ffbit commented Nov 11, 2013

martykube commented Nov 11, 2013

martykube commented Nov 12, 2013

ffbit commented Nov 12, 2013

lock bot commented Oct 25, 2018

aslakhellesoy commented Oct 25, 2018

aslakhellesoy commented Oct 25, 2018