Issue #2 Ensuring features are parsed before formatters are initialised #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -156,12 +156,24 @@ private void printUsage() { | |||
| public List<CucumberFeature> cucumberFeatures(ResourceLoader resourceLoader) { | |||
| return load(resourceLoader, featurePaths, filters, System.out); | |||
| } | |||
|
|
|||
| protected List<Formatter> formatters() { | |||
| if (formatters.isEmpty()){ | |||
There was a problem hiding this comment.
Both the TestNG and the Android modules add additional formatters to the formatters list (using the getFormatters method), so in those cases the formatters list will be non-empty, even thought the formatters has not yet been created from the formattersNames list. A boolean field (formattersCreated?) is needed to keep track whether formatters has be created from the formattersNames list.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
mpkorstanje
pushed a commit
that referenced
this pull request
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion in #651 it was suggested that reports should not be created until we know if there are syntax errors.
The formatters that use a URLOutputStream with a file protocol will all create their report files when the factory creates the formatter which at the moment is done when RuntimeOptions are created
I have added a test to demonstrate this and attempted to fix it.
See https://github.com/tmullender/cucumber-jvm/issues/2 for some explanation of the approach