Let JUnitReporter fire event(s) on the step notifier for every step #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JUnitReporter should for each call to Result either call fireTestIgnored, or call fireTestStarted and fireTestFinished on the step notifier. In strict mode undefined and pending steps should be treated as failed steps, so fireTestStarted and fireTestFinished should be called on the step notifier.
aslakhellesoy
added a commit
that referenced
this pull request
Jun 26, 2014
brasmusson
deleted the
junit-reporter-fire-on-step-notifier-for-every-step
branch
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In strict mode the JUnitReporter currently does not fire any event on the step notifier for undefined or pending steps (neither fireTestIgnored, nor fireTestStarted and fireTestFinished is called). Therefore the JUnit runner of Eclipse display wrong run count when this occurs.
The JUnitReporter should for each call to Result either call fireTestIgnored, or call fireTestStarted and fireTestFinished on the step notifier. In strict mode undefined and pending steps should be treated as failed steps, so fireTestStarted and fireTestFinished should be called on the step notifier.