Only include executed scenarios and steps from outlines in the JSON output #704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not include the Scenario Outline and Examples given as information before the execution of the instantiated scenarios from the outline. This unified the JSON output from Cucumber-JVM regardless of the feature is executed by the command line runner, the JUnit runner of the TestNG runner. The JUnit runner differs from the other by not sending the Scenario Outline and Examples as information to the formatters before executing the instantiated scenarios from the outline, so this commit only affects the output from the command line runner and the TestNG runner.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not include the Scenario Outline and Examples given as information before the execution of the instantiated scenarios from the outline. This unified the JSON output from Cucumber-JVM regardless of the feature is executed by the command line runner, the JUnit runner of the TestNG runner. The JUnit runner differs from the other by not sending the Scenario Outline and Examples as information to the formatters before executing the instantiated scenarios from the outline, so this PR only affects the output from the command line runner and the TestNG runner.
That the JSON output currently differs depending on which runner was used is confusing both for users (see for instance this mailing list post), and tool developer (for instance the Jenkins Cucumber Report plugin, see this discussion on a plugin issue starting here or this discussion on a gherkin issue starting here).
Fixes #681 and fixes cucumber/gherkin#299, it most likely fix also any remaining Cucumber-JVM part of cucumber/gherkin#165.