Make standard out non buffered #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the default output was an OutputStreamWriter. Since this is buffered it resulted in test output being buffered making watching the test output in real time impossible. Now we use a PrintStream which is the type that the System.out stream is anyway, while still retaining the fix intoduced to make the Appender's close() method a no-op.
|
LGTM. Can you fix the formatting? See CONTRIBUTING.md. |
|
Fixed the indenting in the test. Was there anything else I needed to fix up? |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the pretty appender (any appender that writes to standard out should have the same problem) the output comes in fits and spurts. This is really annoying if you are trying to follow the tests. The problem was that the default appender was a Writer not a Stream.