Datatable diff set #731
Merged
Datatable diff set #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great! Could you try to implement it without guava? I really like guava, but version incompatibilities are likely to occur if projects depend on a different version of it. Alternatively we could jarjar it into the |
This reverts commit ef37a5c.
|
I have change the algorithm to deal with duplicate. No need of guava anymore. |
aslakhellesoy
added a commit
that referenced
this pull request
Jun 25, 2014
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datatable.diff allows a diff if and only if lines are in the same order.
It can be a limitation if for readability you want to specify an order in your test but when fetching data, it cames in a different order.
This pull request add this feature.