fix NPE on MethodFormat.getCodeSource

[bySabi]

When use a custom classloader protectionDomain.getCodeSource().getLocation() can return null.

[bySabi]

With some custom classloader protectionDomain.getCodeSource()can be null too.
is safe to define?

 private String getCodeSource(Method method) {
   return method.getDeclaringClass().getName();
}

[paoloambrosio]

On what platform is this NPE happening?

[bySabi]

Well I was testing Cucumber-jvm with Robolectric classloader AsmInstrumentingClassLoader, see my post: https://groups.google.com/forum/#!topic/cukes/Eq4AG4bMo9E

The problem with protectionDomain.getCodeSource() relate to custom classloader who not extend SecureClassLoader class see link: http://docstore.mik.ua/orelly/java-ent/security/ch03_04.htm
Then if possible get NPE with other classloader.

Why not just use? :

 private String getCodeSource(Method method) {
   return method.getDeclaringClass().getName();
}

[aslakhellesoy]

@bySabi the old code gives the path to the source file. Your PR looks good. It's a good fallback for when the source is unavailable.

[brasmusson]

If I read the comments correctly, getProtectionDomain(), getProtectionDomain().getSourceCode() or getProtectionDomain().getSourceCode().getLocation() may return null (on some platforms/class loaders).
Given that (and that the PR currently only handles the first and third case) I think it would be better to use a try - catch construct to handle all these cases:

  try {
    ProtectionDomain protectionDomain = method.getDeclaringClass().getProtectionDomain();
    return protectionDomain.getCodeSource().getLocation().toExternalForm();
  } catch (Exception e) {
    // getProtectionDomain() returns null on some platforms (for example on Android)
    return method.getDeclaringClass().getName();
  }

(the fallback return method.getDeclaringClass().getName(); is maybe not wrong, but kind of redundant since the full message in that case would be:

<qualified class name>.<method name> in <qualified class name>

where the second <qualified class name> comes from the getSourceCode() method)

[bySabi]

Your are right @brasmusson try-catch is a better aproach.

[bySabi]

I create a new PR: #757 when suggested @brasmusson try-catch code.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.