Fix to allow lein test to to run successfully #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(run-cukes) to execute from repl and 'lein test' to succeed.
| @@ -13,4 +13,4 @@ Feature: Cukes | |||
| When I eat 1 "cukes" | |||
| Then I am "sad" | |||
| When I eat 1 "cukes" | |||
| Then I am "meh" | |||
| Then I am "happy" | |||
There was a problem hiding this comment.
This change breaks the build (see Travis). Instead the feature description should be changed from "The last 'Then' ... is failing", to something like "to provoke a failure change the last 'Then' form 'meh' to 'happy'".
|
LGTM except that the latest version has moved. When this is merged we should update CONTRIBUTING.md to add a reminder to update this when we release. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed core.clj and associated deps in project to allow (run-cukes) to execute from repl and 'lein test' to succeed.