-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cucumber is ready to run in OSGi containers #873
Conversation
This uses the maven felix bundle plugin.
RuntimeOptions loads the USAGE.txt on class initialization. However gherkin.util.FixJava is in the gherkin jar/bundle and in an OSGi container the class loader of FixJava does not see the text file, because it is located in the core jar/bundle. Printing the usage text in an OSGi container is not needed, so the code has been changed to lazy load the resource.
Why does it need the snapshot version of cucumber-jvm-deps? And we should probably have this depend on a release of 1.0.4 of that. We cannot release with a snapshot dependency. EDIT: You did this, and I'm a moron. |
Okay I merged cucumber-attic/cucumber-jvm-deps#3, and as soon as I can figure out the right hoops to jump through to release that, you'll have a 1.0.4 with the OSGi Header, and we can make sure the travis builds succeed, and then we can merge this guy :D |
Hi David! Any success on releasing the new deps version? I could update my branch to 1.0.4 If you need anything else, pls let me know. Regards, Hendrik |
@aslakhellesoy I need to know how to sign the release for the cucumber-jvm-deps project (or if you just do it or whatev.) |
@HendrikSP A new deps version has been released, 1.0.5. If you update this and travis passes, we can merge it :) |
Yep - I'm working on it now :-) |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is an upgraded version of pull request of #799
My changes include:
NOTE: Please release cucumber-jvm-deps with my other pull request (see cucumber-attic/cucumber-jvm-deps#3), because this changes make only sense when the jvm-deps bundle has also OSGi headers.
Thank you!