Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IllegalArgumentException on JDK 1.8.0_60 #914

Closed
wants to merge 6 commits into from
Closed

Fix IllegalArgumentException on JDK 1.8.0_60 #914

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
046d98c
Fix IllegalArgumentException on JDK 1.8.0_60
dbcowboy Sep 30, 2015
dd34092
#914 Correct with Code Standards
dbcowboy Oct 2, 2015
66a622c
Revert "#914 Correct with Code Standards"
dbcowboy Oct 2, 2015
b263818
Merge remote-tracking branch 'cucumber/master'
dbcowboy Oct 2, 2015
16aa3b5
#914 Correct with Code Standards
dbcowboy Oct 3, 2015
1f72586
Merge branch 'master' of https://github.com/dbcowboy/cucumber-jvm
dbcowboy Oct 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion java8/src/main/java/cucumber/runtime/java8/ConstantPoolTypeIntrospector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,20 @@ public Type[] getGenericTypes(Class<?> clazz) throws Exception {
}

private String getTypeString(ConstantPool constantPool) {
String[] memberRef = constantPool.getMemberRefInfoAt(constantPool.getSize() - 2);
int size = constantPool.getSize();
String[] memberRef = null;

// find last element in constantPool with valid memberRef
// - previously always at size-2 index but changed with JDK 1.8.0_60
for (int i = size - 1; i > -1; i--) {
try {
memberRef = constantPool.getMemberRefInfoAt(i);
break;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return should be here (instead of break).

} catch (IllegalArgumentException e) {
// eat error; null entry at ConstantPool index?
}
}

return memberRef[2];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here must be exception (instead of return) in case something goes wrong with for loop.

}

Expand Down