Remove the warning about config.cache_classes set to false?

[erikaxel]

We currently output a warning if config.cache_classes is set to false, we do that in this line

cucumber-rails/lib/cucumber/rails.rb

Line 16 in b4ab57e

unless Rails.application.config.cache_classes || defined?(Spring)

Right now there are two issues at least:

• In Rails 7.1 and onwards it is called config.enable_reloading. So new users might not understand which setting to set.
• The Spring guard does not seem to work.

I can take a stab at these issues if you would like to, but before I do that, I wanted to ask, do we really need this warning anymore? We have been running Cucumber with config_classes set to false in our test environment for several years and have never ever seen this problem. The initial warning was from 16 years ago from a bug report that no longer exists, for what I think was Rails 2. This was the earliest mention I could find in the repo: https://github.com/cucumber/cucumber-rails/blob/124b298ede48622769230fea29e04105ca899629/lib/cucumber/rails/world.rb

The only similar error we experience is if you actually change code while running a test. But that goes for rspec and minitest as well, and it does not have a similar warning afaik. I think if you change code on the fly while running tests that you reasonably expect things to go wrong.

My hunch is that with all the changes the last 16 years, in particular with Zeitwerk, that this is no longer an issue. Perhaps we could short cut this and just remove it?

[luke-hill]

I agree that this could potentially be removed. However given I've just done a cut and removed a bunch of stuff about rails 5.x and similar it probably would have made sense to be included in there.

Happy to consider this and a few other items to be removed in the next major

[erikaxel]

Sounds good! Would you like me to do a PR to remove it, or will you handle it yourself?

[luke-hill]

I'm actually going to be off for nearly a month. So all my cucumber priorities will be lapsing for arguably close to the year. So any help is greatly appreciated.