Add #status to Cucumber::Core::Test::Result classes #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdswan
added a commit
to pdswan/cucumber
that referenced
this pull request
May 1, 2015
| Module.new do | ||
| define_method :status do |
There was a problem hiding this comment.
Maybe I'm being picky, but I'm inclined to call this :to_sym. It doesn't sound right to me for a result to have a status. Do you know what I mean?
There was a problem hiding this comment.
Not picky at all, the status is the result, it's reflected in the class name and the predicate methods so it makes more sense to expose it as a version of the result (i.e. it's symbol form) rather than a separate piece of data.
pdswan
force-pushed
the
regression/missing-scenario-status
branch
from
e05e5f2 to
fec6053
Compare
pdswan
force-pushed
the
regression/missing-scenario-status
branch
from
fec6053 to
820c973
Compare
mattwynne
added a commit
that referenced
this pull request
May 6, 2015
Add #status to Cucumber::Core::Test::Result classes
|
Thanks @pdswan! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added for cucumber/common#836