Do not apply the hooks several time when using the retry option

The test case received in the test_case_finished event might be equal
to the test case received from the previous filter when comparing with
'==', but it has the hooks applied to it so it cannot be passed on to
the next filter. Fixes #1098.

History.md

@@ -16,6 +16,7 @@
 
 ### Bugfixes
 
+* Do not apply the hooks to the test case several times when using the retry option ([#1098](https://github.com/cucumber/cucumber-ruby/issues/1098) @brasmusson)
 * Fix bug in comparing empty data tables ([#1097](https://github.com/cucumber/cucumber-ruby/pulls/1097), resolves [#1096](https://github.com/cucumber/cucumber-ruby/issues/1096))
 * Configure Gemfile to fetch cucumber-ruby-wire from git if the repo is not found locally ([#983](https://github.com/cucumber/cucumber-ruby/pulls/983), resolves [#961](https://github.com/cucumber/cucumber-ruby/issues/961))
 * Fix regression displaying CLI help ([#991](https://github.com/cucumber/cucumber-ruby/pull/991) @mattwynne)

lib/cucumber/filters/retry.rb

@@ -12,7 +12,7 @@ def test_case(test_case)
           next unless retry_required?(test_case, event)
 
           test_case_counts[test_case] += 1
-          event.test_case.describe_to(receiver)
+          test_case.describe_to(receiver)
         end
 
         super

spec/cucumber/filters/retry_spec.rb

@@ -33,6 +33,19 @@
     end
   end
 
+  context 'when performing retry' do
+    let(:result) { Cucumber::Core::Test::Result::Failed.new(0, StandardError.new) }
+
+    it 'describes the same test case object each time' do
+      allow(receiver).to receive(:test_case) {|tc|
+        expect(tc).to equal(test_case)
+        configuration.notify :test_case_finished, tc.with_steps(tc.test_steps), result
+      }
+
+      filter.test_case(test_case)
+    end
+  end
+
   context 'consistently failing test case' do
     let(:result) { Cucumber::Core::Test::Result::Failed.new(0, StandardError.new) }