Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/update-history generates bad links #1182

Closed
aslakhellesoy opened this issue Aug 22, 2017 · 11 comments
Closed

scripts/update-history generates bad links #1182

aslakhellesoy opened this issue Aug 22, 2017 · 11 comments
Assignees

Comments

@aslakhellesoy
Copy link
Contributor

2 problems:

  • The Markdown is wrong (missing ])
  • The URL to the issue is wrong (points to API)

Both the script and the History.md needs updating.

/cc @mattwynne @jaysonesmith

@mxygem mxygem self-assigned this Aug 22, 2017
@mattwynne
Copy link
Member

Gah! That'll teach me to write untested code late at night while on whisky

@mxygem
Copy link
Member

mxygem commented Aug 22, 2017

Hah! GG @mattwynne :p It should be easy enough to fix for now until the bash version comes out.

@mxygem
Copy link
Member

mxygem commented Sep 6, 2017

@mattwynne You fixed this in master, yeah?

@mattwynne
Copy link
Member

I did, in 25b33b0

@mattwynne
Copy link
Member

Oh wait, actually I didn't fix the URL to the issue thing.

@mattwynne mattwynne reopened this Sep 6, 2017
@mattwynne
Copy link
Member

links fixed in eed8b2d

@olleolleolle
Copy link
Contributor

The only remaining thing is to get History.md in line with those two changes.

@mxygem
Copy link
Member

mxygem commented Sep 6, 2017

History.md is no more @olleolleolle ! :p Are you referring to adding the changes that @mattwynne made to the update script as needing to be added to the changelog or something different?

@olleolleolle
Copy link
Contributor

@jaysonesmith The Description field mentioned the History.md as a last step; so, I guess, in order to take this to done as defined in there, the changelog needs to avoid the issues, as well.

@mxygem
Copy link
Member

mxygem commented Sep 7, 2017

@olleolleolle Ah, I get what you mean. Pretty sure I nabbed things in #1194. I'd like to also update usernames to point to git profiles, but perhaps that'll be something for another day.

mxygem added a commit that referenced this issue Sep 14, 2017
* Formatting and link fixing for [#1182](cucumber/common#1182)
* Added header from [#251](cucumber/common#251)
@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants