Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic dependency update PRs #1637

Closed
mattwynne opened this issue May 18, 2022 · 8 comments · Fixed by #1639 or #1648
Closed

Automatic dependency update PRs #1637

mattwynne opened this issue May 18, 2022 · 8 comments · Fixed by #1639 or #1648
Labels
🏦 debt Tech debt

Comments

@mattwynne
Copy link
Member

🤔 What's the problem you've observed?

Renovate only looks at the Gemfile so most of our dependencies (which are in the .gemspec) are ignored.

✨ Do you have a proposal for making it better?

Take a look at https://github.com/marvin-bitterlich/renovate-gemspec-minimal-example and see if it works for us.

📚 Any additional context?

This is still an open issue on renovate.


This text was originally generated from a template, then edited by hand. You can modify the template here.

@mattwynne
Copy link
Member Author

Doesn't seem to be working - If I run scripts/update-gemspec I can see that capybara has an update, so renovate should be picking that up.

I've enabled the dependency dashboard for now so we can trigger re-runs, and you can see detailed logging output from renovate at https://app.renovatebot.com/dashboard#github/cucumber/cucumber-ruby

at the moment it looks like it's ignoring the regex manager config:

INFO: Dependency extraction complete
{
  "baseBranch": "main",
  "stats": {
    "managers": {
      "bundler": {
        "fileCount": 1,
        "depCount": 8
      },
      "github-actions": {
        "fileCount": 4,
        "depCount": 10
      }
    },
    "total": {
      "fileCount": 5,
      "depCount": 18
    }
  }
}

@mattwynne
Copy link
Member Author

Weird. In the logs I do see the regex manager running, and detecting the cucumber.gemspec file:

DEBUG: Matched 1 file(s) for manager bundler: Gemfile
DEBUG: Matched 4 file(s) for manager github-actions: .github/actions/test-ruby/action.yml, .github/workflows/cucumber-ruby.yml, .github/workflows/release.yml, .github/workflows/rubocop.yml
DEBUG: Matched 1 file(s) for manager regex: cucumber.gemspec

But it then seems to ignore it:

DEBUG: Found bundler package files
DEBUG: Found github-actions package files
DEBUG: Found 5 package file(s)

@mattwynne
Copy link
Member Author

From the logs:

DEBUG: Manager explicitly enabled in "enabledManagers" config, but found no results. Possible config error?
{
  "manager": "regex"
}

@mattwynne
Copy link
Member Author

I'm continuing my experiments in a fork of the minimal example

mattwynne added a commit that referenced this issue Jun 9, 2022
@mattwynne mattwynne changed the title Have renovate look at the gemspec too Automatic dependency update PRs Jun 9, 2022
@mattwynne
Copy link
Member Author

It looks to me like Dependabot might be a better candidate than Renovate. It's certainly able to draw a dependency graph from the .gemspec, but at the moment our Gemfile (with these environment variable overrides for paths) breaks it.

@mpkorstanje
Copy link
Contributor

Repository owner moved this from In Progress to Done in Ruby automatic dependency updates Dec 25, 2022
@mpkorstanje mpkorstanje reopened this Dec 25, 2022
@mpkorstanje
Copy link
Contributor

You can now replace dependabot with Renovate.

Please use the contents of https://github.com/cucumber/renovate-config/blob/main/renovate.json .

@mattwynne
Copy link
Member Author

Done, thanks for your help with this Rien! 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏦 debt Tech debt
Projects
No open projects
2 participants